feat(codeguruprofiler): add support for ComputePlatform in ProfilingGroup #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinny85
previously approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Thanks a lot for the contribution @SeekerWing !
I have some cosmetic comments - once you've addressed them, remove the pr/do-not-merge label from the Pull Request, and it will be automatically merged.
Thanks again!
packages/@aws-cdk/aws-codeguruprofiler/test/profiling-group.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-codeguruprofiler/test/profiling-group.test.ts
Outdated
Show resolved
Hide resolved
SeekerWing
force-pushed
the
profiler_group_compute
branch
from
73d0b13
to
3fb78ab
Compare
skinny85
approved these changes
Aug 14, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9285
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license