Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): Code.fromDockerBuildAsset #12258

Merged
merged 14 commits into from Feb 18, 2021
Merged

Conversation

@jogold
Copy link
Contributor

@jogold jogold commented Dec 29, 2020

Use the result of a Docker build as code. The runtime code is expected to be
located at /asset in the image.

Also deprecate BundlingDockerImage in favor of DockerImage.

Closes #11914


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Use the result of a Docker build as code. The runtime code is expected to be
located at `/asset` in the image.

Also deprecate `BundlingDockerImage` in favor of `DockerImage`.
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Dec 29, 2020

@jogold
Copy link
Contributor Author

@jogold jogold commented Dec 29, 2020

@mergify mergify bot dismissed eladb’s stale review Dec 29, 2020

Pull request has been modified.

@nija-at nija-at assigned eladb and unassigned nija-at Jan 6, 2021
packages/@aws-cdk/aws-lambda/lib/code.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/bundling.ts Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review Feb 18, 2021

Pull request has been modified.

@@ -36,6 +36,9 @@ runtime code.
* `lambda.Code.fromAsset(path)` - specify a directory or a .zip file in the local
filesystem which will be zipped and uploaded to S3 before deployment. See also
[bundling asset code](#bundling-asset-code).
* `lambda.Code.fromDockerBuildAsset(path, options)` - use the result of a Docker

This comment has been minimized.

@eladb

eladb Feb 18, 2021
Contributor

Let's rename this to fromDockerBuild. I don't see how this can be misinterpreted

@eladb
eladb approved these changes Feb 18, 2021
@eladb
Copy link
Contributor

@eladb eladb commented Feb 18, 2021

Very cool feature

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@eladb
Copy link
Contributor

@eladb eladb commented Feb 18, 2021

@rhboyd worth mentioning in next month's blog

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Feb 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 367359f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants