feat(ecs-patterns): Add support for taskSubnets and securityGroups on QueueProcessingFagateService #12604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…tions on QueueProcessingFagateService
|
Tested the construct with and without the new options using the new (added) integ tests. Created the stacks and validated that the service was consuming the messages from the queue. |
2 tasks
2 tasks
SoManyHs
previously approved these changes
Feb 16, 2021
packages/@aws-cdk/aws-ecs-patterns/test/fargate/test.queue-processing-fargate-service.ts
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
SoManyHs’s stale review
Pull request has been modified.
|
@Mergifyio update |
|
Command
|
|
@Mergifyio update |
|
Command
|
|
@Mergifyio update |
|
Command
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
approved these changes
Feb 17, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12603
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license