Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(s3): Default value documentation of blockPublicAccess is misleading #12983

Merged
merged 6 commits into from
Feb 21, 2021
Merged

chore(s3): Default value documentation of blockPublicAccess is misleading #12983

merged 6 commits into from
Feb 21, 2021

Conversation

iliapolo
Copy link
Contributor

Fixes #12978

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 11, 2021 •
edited
Loading

@iliapolo iliapolo requested a review from a team February 11, 2021 11:42
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Feb 11, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit eb0aabf into master Feb 21, 2021
@mergify mergify bot deleted the epolon/s3-blockPublicAccess-default-doc-fix branch February 21, 2021 19:33
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6f4c3e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb pushed a commit that referenced this pull request Feb 22, 2021
@iliapolo
chore(s3): Default value documentation of blockPublicAccess is misl…
ff6a054 
…eading (#12983)

Fixes #12978 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-s3 Related to Amazon S3 contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-s3): Wrong type stated as the default for Bucket's blockPublicAccess prop
3 participants
@iliapolo @aws-cdk-automation @eladb