Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contrib-guide): add guidance around breaking changes #13347

Merged
merged 7 commits into from
Mar 3, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 2, 2021

At the request of the ECS team, describe the two kinds of breaking
changes separately and describe some tips for dealing with them.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

At the request of the ECS team, describe the two kinds of breaking
changes separately and describe some tips for dealing with them.
@rix0rrr rix0rrr requested a review from a team March 2, 2021 14:32
@rix0rrr rix0rrr self-assigned this Mar 2, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 2, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 2, 2021
eladb
eladb previously requested changes Mar 2, 2021
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this is super helpful and clearly outlined. Thanks @rix0rrr ❤️

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
rix0rrr and others added 4 commits March 3, 2021 09:50
Co-authored-by: Hsing-Hui Hsu <hsinghui@amazon.com>
Co-authored-by: Hsing-Hui Hsu <hsinghui@amazon.com>
…aws/aws-cdk into huijbers/contrib-guide-breaking-changes
@rix0rrr rix0rrr dismissed eladb’s stale review March 3, 2021 09:52

Addressed concerns

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7a8a3c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9e6dc6b into master Mar 3, 2021
@mergify mergify bot deleted the huijbers/contrib-guide-breaking-changes branch March 3, 2021 10:31
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
At the request of the ECS team, describe the two kinds of breaking
changes separately and describe some tips for dealing with them.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants