chore(assertions): replace absentProperty() with absent() and support it as a Matcher type
#16653
Conversation
|
|
I don't understand the problem. What is the expected behaviour here? I believe you are trying to solve the issue #16626. I'll continue the conversation regarding this directly on the issue (since it's easier to follow the conversation). |
kaizencc
changed the title
absentProperty() with absent() and support it as a Matcher type
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
nija-at
changed the title
absentProperty() with absent() and support it as a Matcher typeabsentProperty() with absent() and support it as a Matcher type
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
|
@Mergifyio refresh |
|
Command
|
peterwoodworth
changed the title
absentProperty() with absent() and support it as a Matcher typeabsentProperty() with absent() and support it as Matcher type
peterwoodworth
changed the title
absentProperty() with absent() and support it as Matcher typeabsentProperty() with absent() and support it as a Matcher type
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…port it as a `Matcher` type (#16653) Currently `Match.absentProperty()` is not of type `Matcher` and this introduces a few flaws. For example, `Matcher.isMatcher(Match.absentProperty())` is `false`. This PR fixes this issue by replacing `Match.absentProperty()` with `Match.absent()` that is of type `Matcher`. The decision to change the name is due to supporting this as a general matcher and not just for Properties. BREAKING CHANGE: `Match.absentProperty()` becomes `Match.absent()`, and its type changes from `string` to `Matcher`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…port it as a `Matcher` type (aws#16653) Currently `Match.absentProperty()` is not of type `Matcher` and this introduces a few flaws. For example, `Matcher.isMatcher(Match.absentProperty())` is `false`. This PR fixes this issue by replacing `Match.absentProperty()` with `Match.absent()` that is of type `Matcher`. The decision to change the name is due to supporting this as a general matcher and not just for Properties. BREAKING CHANGE: `Match.absentProperty()` becomes `Match.absent()`, and its type changes from `string` to `Matcher`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Currently
Match.absentProperty()is not of typeMatcherand this introduces a few flaws. For example,Matcher.isMatcher(Match.absentProperty())isfalse.This PR fixes this issue by replacing
Match.absentProperty()withMatch.absent()that is of typeMatcher. The decision to change the name is due to supporting this as a general matcher and not just for Properties.BREAKING CHANGE:
Match.absentProperty()becomesMatch.absent(), and its type changes fromstringtoMatcher.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license