Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v2): minimum supported node version is now v14 #17036

Merged
merged 2 commits into from
Oct 18, 2021
Merged

chore(v2): minimum supported node version is now v14 #17036

merged 2 commits into from
Oct 18, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 18, 2021 •
edited
Loading

This is the current active LTS version and is a good minimum requirement.

Re-introduction of #11964. Fixes #16438

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore(aws-cdk-lib): minimum supported node version is now v14 (#11964)
e807e89 
This is the current active LTS version and is a good minimum
requirement.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@rix0rrr rix0rrr requested a review from a team October 18, 2021 14:20
@rix0rrr rix0rrr self-assigned this Oct 18, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 18, 2021
@rix0rrr rix0rrr changed the title chore(aws-cdk-lib): minimum supported node version is now v14 (#11964) chore(v2): minimum supported node version is now v14 Oct 18, 2021
eladb
eladb approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godspeed

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

RomainMuller
RomainMuller approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e30f781
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d0a27c1 into master Oct 18, 2021
@mergify mergify bot deleted the huijbers/v2-to-node-14 branch October 18, 2021 17:26
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ghost
Copy link

ghost commented Oct 19, 2021

Is this a requirement change for CDK v2 apps?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Oct 19, 2021 •
edited
Loading

@jerry-aws Yes!

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@rix0rrr @TikiTDO
chore(v2): minimum supported node version is now v14 (aws#17036)
e4e09d2 
This is the current active LTS version and is a good minimum requirement.

Re-introduction of aws#11964. Fixes aws#16438


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CDKv2GA]: Upgrade minimum node version to 14 for V2
4 participants
@rix0rrr @aws-cdk-automation @RomainMuller @eladb