Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(secretsmanager): remove reference to Secret.grantUpdate #19151

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

isker
Copy link
Contributor

@isker isker commented Feb 25, 2022

This method does not exist. This mention in the docs is leftover from an abandoned approach in #8600 and should have been reverted.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This method does not exist.  This mention in the docs is leftover from an abandoned approach in !8600 and should have been reverted.
@gitpod-io
Copy link

gitpod-io bot commented Feb 25, 2022

@github-actions github-actions bot added the @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager label Feb 25, 2022
@isker
Copy link
Contributor Author

isker commented Mar 1, 2022

@skinny85 Please take a look as you originally reviewed #8600.

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @isker!

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2c77ef4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2d6a266 into aws:master Mar 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this pull request Mar 11, 2022
This method does not exist.  This mention in the docs is leftover from an abandoned approach in aws#8600 and should have been reverted.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants