chore: add new style integration test snapshots #19802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk of this PR is adding the new style integration test snapshots
that the new `integ-runner` uses. These are snapshots of the cloud
assembly and have folder names like `${testName}.integ.snapshot`.
Some other minor updates were made as part of this change.
1. Updated `integ-runner` to use `synthFast` instead of `synth` to speed
up performance.
2. Make sure the `integ-runner` throws an exit code if any tests fail
3. Updated the test names to include the directory if running from a
parent directory (i.e. `packages/@aws-cdk`).
4. Added the ability to exempt from the update workflow (update workflow
is not yet implemented). If a test is exempt then the snapshot will
not contain any assets. For now this is used for tests that include
very large assets that would drastically increase the size of the
repo.
5. Updated some custom resources to exclude `*.ts` files from the asset
bundle. `.ts` files are already excluded when we publish (`.d.ts`
files are not), and `.js` files are the only thing needed by the
Lambda function anyway. This was causing issues when running a build
because those files in the snapshot would cause `tsc` to fail.
- Updated:
`aws-events-targets/lib/aws-api.ts`
`aws-redshift/lib/private/database-query.ts`
`aws-stepfunctions-tasks/lib/evaluate-expression.ts`
`custom-resources/lib/aws-custom-resource/aws-custom-resource.ts`
`custom-resources/lib/provider-framework/provider.ts`
|
|
1. remove `.cache` directories from the snapshot 2. cleanup `manifest.json` in snapshots, removing trace data
otaviomacedo
approved these changes
Apr 8, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
This PR is a follow up to #19802 which added all of the new integ test snapshots that are used by the new `integ-runner` tool. This PR switches out the old `cdk-integ` tool for the new `integ-runner`. Updates made: 1. Update all `package.json` files to install and use the `integ-runner` 2. Update `cdk-test` to use `integ-runner` 3. Updates snapshots for 2 tests that were changed since #19802 was merged. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
otaviomacedo
pushed a commit
that referenced
this pull request
Apr 11, 2022
The bulk of this PR is adding the new style integration test snapshots
that the new `integ-runner` uses. These are snapshots of the cloud
assembly and have folder names like `${testName}.integ.snapshot`.
Some other minor updates were made as part of this change.
1. Updated `integ-runner` to use `synthFast` instead of `synth` to speed
up performance.
2. Make sure the `integ-runner` throws an exit code if any tests fail
3. Updated the test names to include the directory if running from a
parent directory (i.e. `packages/@aws-cdk`).
4. Added the ability to exempt from the update workflow (update workflow
is not yet implemented). If a test is exempt then the snapshot will
not contain any assets. For now this is used for tests that include
very large assets that would drastically increase the size of the
repo.
5. Updated some custom resources to exclude `*.ts` files from the asset
bundle. `.ts` files are already excluded when we publish (`.d.ts`
files are not), and `.js` files are the only thing needed by the
Lambda function anyway. This was causing issues when running a build
because those files in the snapshot would cause `tsc` to fail.
- Updated:
`aws-events-targets/lib/aws-api.ts`
`aws-redshift/lib/private/database-query.ts`
`aws-stepfunctions-tasks/lib/evaluate-expression.ts`
`custom-resources/lib/aws-custom-resource/aws-custom-resource.ts`
`custom-resources/lib/provider-framework/provider.ts`
----
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)
### Adding new Unconventional Dependencies:
* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)
### New Features
* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
* [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
otaviomacedo
pushed a commit
that referenced
this pull request
Apr 11, 2022
This PR is a follow up to #19802 which added all of the new integ test snapshots that are used by the new `integ-runner` tool. This PR switches out the old `cdk-integ` tool for the new `integ-runner`. Updates made: 1. Update all `package.json` files to install and use the `integ-runner` 2. Update `cdk-test` to use `integ-runner` 3. Updates snapshots for 2 tests that were changed since #19802 was merged. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
The bulk of this PR is adding the new style integration test snapshots
that the new `integ-runner` uses. These are snapshots of the cloud
assembly and have folder names like `${testName}.integ.snapshot`.
Some other minor updates were made as part of this change.
1. Updated `integ-runner` to use `synthFast` instead of `synth` to speed
up performance.
2. Make sure the `integ-runner` throws an exit code if any tests fail
3. Updated the test names to include the directory if running from a
parent directory (i.e. `packages/@aws-cdk`).
4. Added the ability to exempt from the update workflow (update workflow
is not yet implemented). If a test is exempt then the snapshot will
not contain any assets. For now this is used for tests that include
very large assets that would drastically increase the size of the
repo.
5. Updated some custom resources to exclude `*.ts` files from the asset
bundle. `.ts` files are already excluded when we publish (`.d.ts`
files are not), and `.js` files are the only thing needed by the
Lambda function anyway. This was causing issues when running a build
because those files in the snapshot would cause `tsc` to fail.
- Updated:
`aws-events-targets/lib/aws-api.ts`
`aws-redshift/lib/private/database-query.ts`
`aws-stepfunctions-tasks/lib/evaluate-expression.ts`
`custom-resources/lib/aws-custom-resource/aws-custom-resource.ts`
`custom-resources/lib/provider-framework/provider.ts`
----
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)
### Adding new Unconventional Dependencies:
* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)
### New Features
* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
* [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
This PR is a follow up to aws#19802 which added all of the new integ test snapshots that are used by the new `integ-runner` tool. This PR switches out the old `cdk-integ` tool for the new `integ-runner`. Updates made: 1. Update all `package.json` files to install and use the `integ-runner` 2. Update `cdk-test` to use `integ-runner` 3. Updates snapshots for 2 tests that were changed since aws#19802 was merged. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this PR is adding the new style integration test snapshots
that the new
integ-runneruses. These are snapshots of the cloudassembly and have folder names like
${testName}.integ.snapshot.Some other minor updates were made as part of this change.
integ-runnerto usesynthFastinstead ofsynthto speedup performance.
integ-runnerthrows an exit code if any tests failparent directory (i.e.
packages/@aws-cdk).is not yet implemented). If a test is exempt then the snapshot will
not contain any assets. For now this is used for tests that include
very large assets that would drastically increase the size of the
repo.
*.tsfiles from the assetbundle.
.tsfiles are already excluded when we publish (.d.tsfiles are not), and
.jsfiles are the only thing needed by theLambda function anyway. This was causing issues when running a build
because those files in the snapshot would cause
tscto fail.aws-events-targets/lib/aws-api.tsaws-redshift/lib/private/database-query.tsaws-stepfunctions-tasks/lib/evaluate-expression.tscustom-resources/lib/aws-custom-resource/aws-custom-resource.tscustom-resources/lib/provider-framework/provider.tsAll Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integto deploy the infrastructure and generate the snapshot (i.e.cdk-integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license