Skip to content

build: workaround for jsii exit code issue #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2019
Merged

build: workaround for jsii exit code issue #2200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ee6a3
build: workaround for jsii exit code issue
Apr 8, 2019
93b1f7c
update comment
Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/cdk-build-tools/lib/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ import { Timers } from "./timer";
* Run the compiler on the current package
*/
export async function compileCurrentPackage(timers: Timers, compilers: CompilerOverrides = {}): Promise<void> {
await shell(packageCompiler(compilers), timers);
const stdout = await shell(packageCompiler(compilers), timers);

// WORKAROUND: jsii 0.8.2 does not exit with non-zero on compilation errors
// until this is released: https://github.com/awslabs/jsii/pull/442
if (stdout.trim()) {
throw new Error(`Compilation failed`);
}

// Find files in bin/ that look like they should be executable, and make them so.
const scripts = currentPackageJson().bin || {};
Expand Down