Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cfnspec): v101.0.0 introduced specific types on several types that previously were typed as json #23448

Merged
merged 33 commits into from
Dec 23, 2022

Conversation

madeline-k
Copy link
Contributor

@madeline-k madeline-k commented Dec 22, 2022

This PR reverts all changes where a type changed from Json to a specific type in CfnSpec v101.0.0. See 3951f09

  • 000_AWS_Backup.json
  • 000_AWS_CloudFormation.json
  • 000_AWS_CodeGuruProfiler.json
  • 000_AWS_Config.json
  • 000_AWS_Connect.json
  • 000_AWS_DataBrew.json
  • 000_AWS_EC2.json
  • 000_AWS_ECR.json
  • 000_AWS_ElastiCache.json
  • 000_AWS_FIS.json
  • 000_AWS_Forecast.json
  • 000_AWS_GreengrassV2.json
  • 000_AWS_IoT.json
  • 000_AWS_IoTAnalytics.json
  • 000_AWS_IoTCoreDeviceAdvisor.json
  • 000_AWS_IoTFleetWise.json
  • 000_AWS_IoTSiteWise.json
  • 000_AWS_IoTTwinMaker.json
  • 000_AWS_IoTWireless.json
  • 000_AWS_LakeFormation.json
  • 000_AWS_Lex.json
  • 000_AWS_LookoutEquipment.json
  • 000_AWS_Macie.json
  • 000_AWS_MemoryDB.json
  • 000_AWS_Personalize.json
  • 000_AWS_Redshift.json
  • 000_AWS_Route53.json
  • 000_AWS_S3.json
  • 000_AWS_S3ObjectLambda.json
  • 000_AWS_S3Outposts.json
  • 000_AWS_SageMaker.json
  • 000_AWS_Scheduler.json
  • 000_AWS_StepFunctions.json
  • 000_AWS_Timestream.json
  • 000_AWS_Transfer.json
  • 000_AWS_WAFv2.json

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 22, 2022

@github-actions github-actions bot added the p2 label Dec 22, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 22, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team December 22, 2022 23:38
@madeline-k madeline-k changed the title AWS Backup fix(cfnspec): v101.0.0 introduced specific types on several types that previously were typed as json Dec 22, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@madeline-k madeline-k added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 23, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 23, 2022 00:58

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bcb26d5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4fbc182 into main Dec 23, 2022
@mergify mergify bot deleted the madeline-k/fix-cfn-spec-primitive-type-json branch December 23, 2022 16:58
@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

madeline-k added a commit that referenced this pull request Dec 23, 2022
…t previously were typed as json (#23448)

This PR reverts all changes where a type changed from `Json` to a specific type in CfnSpec v101.0.0. See 3951f09 

- [x] 000_AWS_Backup.json
- [x] 000_AWS_CloudFormation.json
- [x] 000_AWS_CodeGuruProfiler.json
- [x] 000_AWS_Config.json
- [x] 000_AWS_Connect.json
- [x] 000_AWS_DataBrew.json
- [x] 000_AWS_EC2.json
- [x] 000_AWS_ECR.json
- [x] 000_AWS_ElastiCache.json
- [x] 000_AWS_FIS.json
- [x] 000_AWS_Forecast.json
- [x] 000_AWS_GreengrassV2.json
- [x] 000_AWS_IoT.json
- [ ] ~000_AWS_IoTAnalytics.json~
- [x] 000_AWS_IoTCoreDeviceAdvisor.json
- [ ] ~000_AWS_IoTFleetWise.json~
- [x] 000_AWS_IoTSiteWise.json
- [x] 000_AWS_IoTTwinMaker.json
- [x] 000_AWS_IoTWireless.json
- [ ] ~000_AWS_LakeFormation.json~
- [x] 000_AWS_Lex.json
- [x] 000_AWS_LookoutEquipment.json
- [ ] ~000_AWS_Macie.json~
- [x] 000_AWS_MemoryDB.json
- [x] 000_AWS_Personalize.json
- [x] 000_AWS_Redshift.json
- [x] 000_AWS_Route53.json
- [x] 000_AWS_S3.json
- [x] 000_AWS_S3ObjectLambda.json
- [x] 000_AWS_S3Outposts.json
- [x] 000_AWS_SageMaker.json
- [ ] ~000_AWS_Scheduler.json~
- [ ] ~000_AWS_StepFunctions.json~
- [ ] ~000_AWS_Timestream.json~
- [x] 000_AWS_Transfer.json
- [x] 000_AWS_WAFv2.json

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
…t previously were typed as json (aws#23448)

This PR reverts all changes where a type changed from `Json` to a specific type in CfnSpec v101.0.0. See aws@3951f09 

- [x] 000_AWS_Backup.json
- [x] 000_AWS_CloudFormation.json
- [x] 000_AWS_CodeGuruProfiler.json
- [x] 000_AWS_Config.json
- [x] 000_AWS_Connect.json
- [x] 000_AWS_DataBrew.json
- [x] 000_AWS_EC2.json
- [x] 000_AWS_ECR.json
- [x] 000_AWS_ElastiCache.json
- [x] 000_AWS_FIS.json
- [x] 000_AWS_Forecast.json
- [x] 000_AWS_GreengrassV2.json
- [x] 000_AWS_IoT.json
- [ ] ~000_AWS_IoTAnalytics.json~
- [x] 000_AWS_IoTCoreDeviceAdvisor.json
- [ ] ~000_AWS_IoTFleetWise.json~
- [x] 000_AWS_IoTSiteWise.json
- [x] 000_AWS_IoTTwinMaker.json
- [x] 000_AWS_IoTWireless.json
- [ ] ~000_AWS_LakeFormation.json~
- [x] 000_AWS_Lex.json
- [x] 000_AWS_LookoutEquipment.json
- [ ] ~000_AWS_Macie.json~
- [x] 000_AWS_MemoryDB.json
- [x] 000_AWS_Personalize.json
- [x] 000_AWS_Redshift.json
- [x] 000_AWS_Route53.json
- [x] 000_AWS_S3.json
- [x] 000_AWS_S3ObjectLambda.json
- [x] 000_AWS_S3Outposts.json
- [x] 000_AWS_SageMaker.json
- [ ] ~000_AWS_Scheduler.json~
- [ ] ~000_AWS_StepFunctions.json~
- [ ] ~000_AWS_Timestream.json~
- [x] 000_AWS_Transfer.json
- [x] 000_AWS_WAFv2.json

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
…t previously were typed as json (aws#23448)

This PR reverts all changes where a type changed from `Json` to a specific type in CfnSpec v101.0.0. See aws@3951f09 

- [x] 000_AWS_Backup.json
- [x] 000_AWS_CloudFormation.json
- [x] 000_AWS_CodeGuruProfiler.json
- [x] 000_AWS_Config.json
- [x] 000_AWS_Connect.json
- [x] 000_AWS_DataBrew.json
- [x] 000_AWS_EC2.json
- [x] 000_AWS_ECR.json
- [x] 000_AWS_ElastiCache.json
- [x] 000_AWS_FIS.json
- [x] 000_AWS_Forecast.json
- [x] 000_AWS_GreengrassV2.json
- [x] 000_AWS_IoT.json
- [ ] ~000_AWS_IoTAnalytics.json~
- [x] 000_AWS_IoTCoreDeviceAdvisor.json
- [ ] ~000_AWS_IoTFleetWise.json~
- [x] 000_AWS_IoTSiteWise.json
- [x] 000_AWS_IoTTwinMaker.json
- [x] 000_AWS_IoTWireless.json
- [ ] ~000_AWS_LakeFormation.json~
- [x] 000_AWS_Lex.json
- [x] 000_AWS_LookoutEquipment.json
- [ ] ~000_AWS_Macie.json~
- [x] 000_AWS_MemoryDB.json
- [x] 000_AWS_Personalize.json
- [x] 000_AWS_Redshift.json
- [x] 000_AWS_Route53.json
- [x] 000_AWS_S3.json
- [x] 000_AWS_S3ObjectLambda.json
- [x] 000_AWS_S3Outposts.json
- [x] 000_AWS_SageMaker.json
- [ ] ~000_AWS_Scheduler.json~
- [ ] ~000_AWS_StepFunctions.json~
- [ ] ~000_AWS_Timestream.json~
- [x] 000_AWS_Transfer.json
- [x] 000_AWS_WAFv2.json

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants