fix(apigateway): allow overriding apiKeyRequired on methods #25682
Conversation
RestApi has the ability to set the apiKeyRequired option for all methods via defaultMethodOptions. Setting this option on a method should override the value set in defaultMethodOptions, but it doesn't work. This commit fixes the behaviour and adds a test. Mentioned in aws#8827
|
|
github-actions
bot
added
admired-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -299,7 +299,7 @@ describe('lambda api', () => { | |||
| ResourceId: { Ref: 'lambdarestapiproxyE3AE07E3' }, | |||
| AuthorizationType: 'NONE', | |||
| AuthorizerId: Match.absent(), | |||
| ApiKeyRequired: Match.absent(), | |||
| ApiKeyRequired: false, | |||
There was a problem hiding this comment.
This should be the correct value given that it's set here
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
Hey, this looks good to me. Thank you for your contributing. Getting a second opinion from @corymhall. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
RestApi has the ability to set the apiKeyRequired option for all methods via defaultMethodOptions.
Setting this option on a method should override the value set in defaultMethodOptions, but it doesn't work.
This commit fixes the behaviour and adds a test.
Mentioned in #8827
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license