Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment #25944

Merged
merged 13 commits into from
Jun 12, 2023

Conversation

akshaypilankar
Copy link
Contributor

computeEnvironmentName property was missing in FargateComputeEnvironment due to which ComputeEnvironmentName property set on the resulting AWS::Batch::ComputeEnvironment resource in the outputted CloudFormation.
Updated managed-compute-environment to reflect the fix made in FargateComputeEnvironment.

Closes #25794.

@gitpod-io
Copy link

gitpod-io bot commented Jun 12, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 12, 2023 16:20
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@akshaypilankar akshaypilankar changed the title fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment #25805 fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment Jun 12, 2023
@comcalvi comcalvi changed the title fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment Jun 12, 2023
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for reopening this!

@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 12, 2023
@comcalvi
Copy link
Contributor

Adding the exempt-integ label because the snapshot was actually wrong before and I didn't catch it, this update to the snapshot is correcting it and we don't need to change the actual test code.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 12, 2023 18:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 70cc458
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fb9f559 into aws:main Jun 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@akshaypilankar
Copy link
Contributor Author

@comcalvi Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_alpha: FargateComputeEnvironment compute_environment_name not being respected
3 participants