-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS #25958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
5d28c51
to
ecf575c
Compare
ecf575c
to
204e910
Compare
Exemption Request: I could not find any existing integration tests specifically for the vpc context provider. Please let me know in case I missed something |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When I do Vpc.fromLookup in a VPC that has subnets with a default route to a TransitGateway the subnet is detected as
PRIVATE_ISOLATED
instead ofPRIVATE_WITH_EGRESS
This PR adds the detection of subnets with TGW routes as
PRIVATE_WITH_EGRESS
instead ofPRIVATE_ISOLATED
.This is potentially a breaking change depending on what is the expected behaviour. To me it seemed rather missed accidentally given that this previous PR mentions that
PRIVATE_WITH_EGRESS
was introduced also for Transit Gateways.Closes #25626
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license