Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS #25958

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

bruecktech
Copy link
Contributor

@bruecktech bruecktech commented Jun 13, 2023

When I do Vpc.fromLookup in a VPC that has subnets with a default route to a TransitGateway the subnet is detected as PRIVATE_ISOLATED instead of PRIVATE_WITH_EGRESS
This PR adds the detection of subnets with TGW routes as PRIVATE_WITH_EGRESS instead of PRIVATE_ISOLATED.

This is potentially a breaking change depending on what is the expected behaviour. To me it seemed rather missed accidentally given that this previous PR mentions that PRIVATE_WITH_EGRESS was introduced also for Transit Gateways.

Closes #25626


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 13, 2023

@bruecktech bruecktech changed the title Detect subnet with TGW route as private Detect subnet with TGW route as PRIVATE_WITH_EGRESS Jun 13, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 13, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 13, 2023 11:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 13, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jun 13, 2023
@bruecktech bruecktech changed the title Detect subnet with TGW route as PRIVATE_WITH_EGRESS feat(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS Jun 13, 2023
@bruecktech bruecktech changed the title feat(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS fix(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS Jun 13, 2023
@bruecktech
Copy link
Contributor Author

Exemption Request: I could not find any existing integration tests specifically for the vpc context provider. Please let me know in case I missed something

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 13, 2023
@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 14, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 14, 2023
@corymhall corymhall added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jun 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 15, 2023 09:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jun 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2f73b1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 49643d6 into aws:main Jun 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vpc: PRIVATE_WITH_EGRESS not getting applied with route to TransitGateway
3 participants