Skip to content

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 28, 2019

In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing S3
Notification Destinations into @aws-cdk/aws-s3-notifications.

Fixes #2445.

BREAKING CHANGE: using a Topic, Queue or Lambda as bucket notification
destination now requires an integration object from the
@aws-cdk/aws-s3-notifications package.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

rix0rrr added 6 commits May 24, 2019 17:40
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing S3
Notification Destinations into `@aws-cdk/aws-s3-notifications`.

Fixes #2445.

BREAKING CHANGE: using a Topic, Queue or Lambda as bucket notification
destination now requires an integration object from the
`@aws-cdk/aws-s3-notifications` package.
@rix0rrr rix0rrr requested a review from a team as a code owner May 28, 2019 14:45
@rix0rrr rix0rrr merged commit 185951c into master May 29, 2019
@rix0rrr rix0rrr deleted the huijbers/s3-notifications branch May 29, 2019 09:58
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
…appable (#27197)

1. Add GraphQLSchema as another AppSync resource that can be hotswapped
2. For all AppSync resources, accept the change in S3 assets/files instead of just inline code as a candidate for hotswap
3. Make pipeline resolvers hotswappable by resolving the functionId of AppSync functions.

Closes #2659, #24112, #24113.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-s3-notifications
3 participants