Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): CloudFront Function runtime property #28099

Merged
merged 26 commits into from
Dec 29, 2023

Conversation

watany-dev
Copy link
Contributor

@watany-dev watany-dev commented Nov 22, 2023

fixed #28163
This provides an option to change the runtime for CloudFront Functions. This makes it easier to access the CloudFront KeyValueStore.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-functionconfig.html


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 22, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 22, 2023 07:55
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@watany-dev
Copy link
Contributor Author

Sorry, I think it's failing to push the snapshot.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 22, 2023 13:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mikewrighton mikewrighton changed the title feat(cloudfront): Setting Runtime of CF2 feat(cloudfront): setting Runtime of CF2 Nov 22, 2023
mikewrighton
mikewrighton previously approved these changes Nov 22, 2023
@mikewrighton mikewrighton changed the title feat(cloudfront): setting Runtime of CF2 feat(cloudfront): setting the runtime of a CloudFront Function Nov 22, 2023
@mergify mergify bot dismissed mikewrighton’s stale review November 22, 2023 15:41

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2023
Comment on lines 9 to 15
const cfFunctionRequest = new cloudfront.Function(stack, 'FunctionRequest', {
code: cloudfront.FunctionCode.fromInline('function handler(event) { return event.request }'),
});

const cfFunctionResponse = new cloudfront.Function(stack, 'FunctionResponse', {
code: cloudfront.FunctionCode.fromInline('function handler(event) { return event.response }'),
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it would be better to use a new parameter FunctionRuntime.JS_2_0 as well, what do you think?

Copy link
Contributor

@go-to-k go-to-k Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It seems that @mikewrighton previously approved. See this comment if you need me to, otherwise I just approve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you say is true. I am happy to report that I have changed to a meaningful integ test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 24, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2023
@github-actions github-actions bot added the feature-request A feature should be added or improved. label Nov 28, 2023
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Dec 18, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 18, 2023
@mergify mergify bot dismissed kaizencc’s stale review December 21, 2023 02:10

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 21, 2023
kaizencc
kaizencc previously approved these changes Dec 22, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @watany-dev!

@mergify mergify bot dismissed kaizencc’s stale review December 23, 2023 14:13

Pull request has been modified.

/**
* The Runtime of the function.
*/
readonly functionRuntime: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly functionRuntime: string;
readonly functionRuntime?: string;

Build is failing with:

err  - IFACE aws-cdk-lib.aws_cloudfront.FunctionAttributes: newly required property 'functionRuntime' added: input to aws-cdk-lib.aws_cloudfront.Function.fromFunctionAttributes [strengthened:aws-cdk-lib.aws_cloudfront.FunctionAttributes]

Looks like we cannot require this prop to fromFunctionAttributes and instead will have to default to the original runtime, or throw an error if not provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaizencc
We decided to make it an arbitrary property. If not specified, the Default value, runtime1.0, is specified as before.

Copy link
Contributor

mergify bot commented Dec 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 29, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 783aed1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9b466ae into aws:main Dec 29, 2023
12 checks passed
Copy link
Contributor

mergify bot commented Dec 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
fixed aws#28163
This provides an option to change the runtime for CloudFront Functions. This makes it easier to access the CloudFront KeyValueStore.


https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-functionconfig.html

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
#28099 added this file erroneously. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
#28099 added this file erroneously. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cloudfront: Support cloudfront-js-2.0 runtime
5 participants