-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront-origin): adding FunctionUrlOrigin #29101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
export interface FunctionUrlOriginProps extends cloudfront.OriginProps { | ||
/** | ||
* Specifies how long, in seconds, CloudFront waits for a response from the origin. | ||
* The valid range is from 1 to 180 seconds, inclusive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing the max read timeout as 60 seconds https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-customoriginconfig.html#cfn-cloudfront-distribution-customoriginconfig-originreadtimeout. Where does the 180 seconds come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in reference to this code; I added this because Note was missing.
/** | |
* Specifies how long, in seconds, CloudFront waits for a response from the origin, also known as the origin response timeout. | |
* The valid range is from 1 to 180 seconds, inclusive. | |
* | |
* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota | |
* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time. | |
* | |
* @default Duration.seconds(30) | |
*/ | |
readonly readTimeout?: cdk.Duration; | |
/** | |
* Specifies how long, in seconds, CloudFront persists its connection to the origin. | |
* The valid range is from 1 to 180 seconds, inclusive. | |
* | |
* Note that values over 60 seconds are possible only after a limit increase request for the origin response timeout quota | |
* has been approved in the target account; otherwise, values over 60 seconds will produce an error at deploy time. | |
* | |
* @default Duration.seconds(5) | |
*/ | |
readonly keepaliveTimeout?: cdk.Duration; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
|
||
/** | ||
* Specifies how long, in seconds, CloudFront persists its connection to the origin. | ||
* The valid range is from 1 to 180 seconds, inclusive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I just have one small question.
847b2d3
to
9208568
Compare
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Reason for this change `origins.httpOrigin` requires a trick to specify the Lambda Functions URL. ### Description of changes This eases that pain and simplifies integration. ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Reason for this change
origins.httpOrigin
requires a trick to specify the Lambda Functions URL.Description of changes
This eases that pain and simplifies integration.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license