Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-targets): support for RedshiftDataParameters #29462

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat(events-targets): support for RedshiftDataParameters #29462

wants to merge 27 commits into from

Conversation

Rizxcviii
Copy link
Contributor

@Rizxcviii Rizxcviii commented Mar 12, 2024 •
edited

Issue # (if applicable)

Closes #15712 .

Reason for this change

RedshiftDataParameters allow for a redshift query to be scheduled. This feature adds that in

Description of changes

Added in the event target and the parameter into aws-events

Description of how you validated changes

Added unit tests + integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 12, 2024 15:09
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Mar 12, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Rizxcviii Rizxcviii changed the title feat(aws-events): Scheduling Redshift Queries feat(events): scheduling Redshift Queries Mar 12, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 12, 2024 15:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Rizxcviii Rizxcviii changed the title feat(events): scheduling Redshift Queries feat(events-targets): scheduling Redshift Queries Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@Rizxcviii Rizxcviii changed the title feat(events-targets): scheduling Redshift Queries feat(events-targets): support for RedshiftDataParameters without the need for an L1 escape hatch Mar 14, 2024
@Rizxcviii Rizxcviii changed the title feat(events-targets): support for RedshiftDataParameters without the need for an L1 escape hatch feat(events-targets): support for RedshiftDataParameters Mar 14, 2024
@Rizxcviii
Copy link
Contributor Author

Clarification request: One workflow is failing, and I am not sure what the reason is?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 14, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@mergify mergify bot dismissed jfuss’s stale review March 19, 2024 16:49

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from jfuss March 19, 2024 17:17
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 19, 2024
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/repo-metrics-monthly.yml without workflows permission

@Rizxcviii
Copy link
Contributor Author

update

❌ Mergify doesn't have permission to update

Is this an issue on my end?

@Rizxcviii
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 23, 2024

update

✅ Branch has been successfully updated

@Rizxcviii
Copy link
Contributor Author

@jfuss @TheRealAmazonKendra Could I get a review please? Thank you

@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@manmartgarc
Copy link

bump, need this!

@Rizxcviii
Copy link
Contributor Author

@jfuss @TheRealAmazonKendra I'm still waiting for a review, I've done all the changes requested :)

@manmartgarc
Copy link

Bump

@Rizxcviii
Copy link
Contributor Author

bump @jfuss @TheRealAmazonKendra

@Rizxcviii
Copy link
Contributor Author

@jfuss @TheRealAmazonKendra Are there still issues with this PR? I've done everything that's asked, but I haven't gotten a response from my changes. I've also given points for the other queries for my justification. Is there anything left to do?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ef708c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@jfuss jfuss Awaiting requested review from jfuss

At least 1 approving review is required to merge this pull request.

Assignees

@jfuss jfuss

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-events-targets): Add scheduling a Redshift query to "Event Targets for Amazon EventBridge"
5 participants
@Rizxcviii @TheRealAmazonKendra @manmartgarc @aws-cdk-automation @jfuss