Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): regex in DistributedMap label is incorrectly escaping characters #29765

Merged

Conversation

piurafunk
Copy link
Contributor

Regex is incorrect. Switching to basic regex. Fixing regex to properly escape special characters

Reason for this change

Regex was incorrectly escaping the ] character, and as such was falsely returning true. It also seemed to be interpreting the \ characters incorrectly, so I switched to a regex literal in line to fix that.

Description of changes

Switch from RegExp object to inline regex.
Fix regex to correctly escape ] character.

Description of how you validated changes

Running in Node CLI, such as:

> /[\s\?\*\<\>\{\}\\[\]\:\;\,\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]/gi.test(' ') 
true

Running in Chrome Dev Tools console, such as:

new RegExp("/[\s\?\*\<\>\{\}\\[\]\:\;\,\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]/gi").test(' ')
false

no

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Regex is incorrect. Switching to basic regex. Fixing regex to properly escape special characters
@github-actions github-actions bot added the p2 label Apr 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2024 16:59
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 8, 2024
@mergify mergify bot mentioned this pull request Apr 8, 2024
1 task
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@piurafunk piurafunk changed the title fix(stepfunctions): Fix DistributedMap label regex fix(stepfunctions): fix DistributedMap label regex Apr 8, 2024
@piurafunk
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 8, 2024
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(stepfunctions): fix DistributedMap label regex fix(stepfunctions): regex in DistributedMap label is incorrectly escaping characters Apr 17, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 17, 2024 01:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 17, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 17, 2024 01:45

Pull request has been modified.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 17, 2024 19:29

Pull request has been modified.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 29, 2024 21:57

Pull request has been modified.

moelasmar
moelasmar previously approved these changes Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed moelasmar’s stale review April 30, 2024 23:35

Pull request has been modified.

Copy link
Contributor

mergify bot commented May 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f35147b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7c4eb71 into aws:main May 1, 2024
9 checks passed
Copy link
Contributor

mergify bot commented May 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants