Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): eventbridge pipes pipes-data vpc endpoint #30246

Merged
merged 7 commits into from
May 29, 2024

Conversation

Liversticks
Copy link
Contributor

Issue # (if applicable)

Closes #30015 .

Reason for this change

Same as #30033, but done with chore instead of feat.

EventBridge Pipes recently added PrivateLink support for event delivery (what's new). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data (source).

Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2024 23:30
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 16, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Liversticks Liversticks changed the title chore(ec2): EventBridge Pipes pipes-data vpc endpoint chore(ec2): eventbridge pipes pipes-data vpc endpoint May 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 16, 2024 23:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 16, 2024
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented May 29, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented May 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 29, 2024
Copy link
Contributor

mergify bot commented May 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2cd93bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d27de72 into aws:main May 29, 2024
9 checks passed
Copy link
Contributor

mergify bot commented May 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
### Issue # (if applicable)

Closes aws#30015 .

### Reason for this change

Same as aws#30033, but done with `chore` instead of `feat`.

> EventBridge Pipes recently added PrivateLink support for event delivery [(what's new)](https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data [(source)](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html). 

### Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

### Description of how you validated changes

N/A

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this pull request Jun 10, 2024
### Issue # (if applicable)

Closes aws#30015 .

### Reason for this change

Same as aws#30033, but done with `chore` instead of `feat`.

> EventBridge Pipes recently added PrivateLink support for event delivery [(what's new)](https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data [(source)](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html). 

### Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

### Description of how you validated changes

N/A

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipes): Add EventBridge Pipes event delivery VPC Endpoint Service
3 participants