Skip to content

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jun 24, 2019

Extract the AwsCustomResource construct to a separate module called @aws-cdk/custom-resources, dedicated to special custom resources such as this one.

Also, stop bundling the entire AWS SDK and instead extract apis/metadata.json during build time which fixes #2951.

BREAKING CHANGE: The AwsCustomResource class was moved to a new module called @aws-cdk/custom-resource


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


Extract the AwsCustomResource construct to a separate module
called @aws-cdk/customresources, dedicated to special custom resources
such as this one.

Fixes #2951
@eladb eladb requested a review from a team as a code owner June 24, 2019 10:02
@eladb
Copy link
Contributor Author

eladb commented Jun 24, 2019

@jogold FYI

@eladb eladb changed the title refactor(cloudformation): extract "customresources" module refactor(cloudformation): extract "custom-resources" module Jun 24, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cloudformation bundles aws-sdk
4 participants