Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): add otel-sqs-handler to the AdotLambdaLayerType enum #30314

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 23, 2024

Issue # (if applicable)

Closes #30310 .

Reason for this change

Missing enum option of otel-sqs-handler

Description of changes

Add SQS_HANDLER option

Description of how you validated changes

I verified that the correct values were set in the environment variables after deploying. Since only an enum option was added, I determined that adding unit tests or integration tests was unnecessary.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels May 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 23, 2024 00:16
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label May 23, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 23, 2024
@xazhao xazhao self-assigned this May 24, 2024
This was referenced May 27, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 12, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 26, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 94befb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 79c7796 into aws:main Jul 26, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Jul 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
@mazyu36 mazyu36 deleted the lambda-otel-sqs-30310 branch July 26, 2024 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda: AdotLambdaExecWrapper is missing an element for /opt/otel-sqs-handler
4 participants