Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove apis and tests that were only published in v1 for pipelines #31098

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra commented Aug 13, 2024

DELETED

All of this code and the associated tests were for CDK Pipelines V1, which was never released to cdk v2. All of the APIs are stripped from the distribution before publishing so this is just code cleanup and this will contain no breaking changes.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 13, 2024 21:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 13, 2024
@TheRealAmazonKendra
Copy link
Contributor Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Aug 13, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 14, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy/ apis are all in https://github.com/aws/aws-cdk/blob/main/deprecated_apis.txt.

Test changes move the 'modern' part of the 'modern vs legacy comparison' tests to simply be the test.

Readme changes are majority formatting and no-change markdown syntax.

Copy link
Contributor

mergify bot commented Aug 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 14, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 33624c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8b072c into main Aug 14, 2024
14 of 15 checks passed
Copy link
Contributor

mergify bot commented Aug 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the TheRealAmazonKendra/v1-cleanup branch August 14, 2024 18:25
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants