Skip to content

Conversation

alvazjor
Copy link
Contributor

@alvazjor alvazjor commented Sep 2, 2025

Issue # (if applicable)

Reason for this change

PR builds are failing with Error: @aws-cdk.aws-iot-alpha-README-L146.ts:9:26 - error TS2307: Cannot find module '@aws-cdk/aws-iot-actions-alpha' or its corresponding type declarations. lately. This change should fix that issue.

Description of changes

Added missing @aws-cdk/aws-iot-actions-alpha dependency

Describe any new or updated permissions being added

NA

Description of how you validated changes

Followed PRs that solved similar issues

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 2, 2025 14:52
@github-actions github-actions bot added the p2 label Sep 2, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@leonmk-aws leonmk-aws self-assigned this Sep 2, 2025
@vishaalmehrishi
Copy link
Contributor

The commit message should have fix(aws-iot-actions-alpha):...

@leonmk-aws
Copy link
Contributor

leonmk-aws commented Sep 2, 2025

The commit message should have fix(aws-iot-actions-alpha):...

@vishaalmehrishi Do we want this fix to appear in the changelog ? It's not a fixing user facing errors, so I changed it to chore(aws-iot-actions-alpha) for now

@leonmk-aws leonmk-aws changed the title fix: add missing rosetta dependency chore(aws-iot-actions-alpha): add missing rosetta dependency Sep 2, 2025
@vishaalmehrishi
Copy link
Contributor

vishaalmehrishi commented Sep 2, 2025

The commit message should have fix(aws-iot-actions-alpha):...

@vishaalmehrishi Do we want this fix to appear in the changelog ? It's not a fixing user facing errors, so I changed it to chore(aws-iot-actions-alpha) for now

I don't think it matters too much, unless we have some requirement to remove these. Also, we need to change the commit message, since that's what shows up in the commit history. The PR title is less important.

@alvazjor alvazjor changed the title chore(aws-iot-actions-alpha): add missing rosetta dependency chore(iot-actions-alpha): add missing rosetta dependency Sep 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 2, 2025 15:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 2, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 2, 2025
Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fead876 into main Sep 2, 2025
56 checks passed
@mergify mergify bot deleted the alvazjor/jsii-rosetta-fix branch September 2, 2025 15:26
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants