-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(iot-actions-alpha): add missing rosetta dependency #35400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
The commit message should have |
@vishaalmehrishi Do we want this fix to appear in the changelog ? It's not a fixing user facing errors, so I changed it to chore(aws-iot-actions-alpha) for now |
I don't think it matters too much, unless we have some requirement to remove these. Also, we need to change the commit message, since that's what shows up in the commit history. The PR title is less important. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
PR builds are failing with
Error: @aws-cdk.aws-iot-alpha-README-L146.ts:9:26 - error TS2307: Cannot find module '@aws-cdk/aws-iot-actions-alpha' or its corresponding type declarations.
lately. This change should fix that issue.Description of changes
Added missing
@aws-cdk/aws-iot-actions-alpha
dependencyDescribe any new or updated permissions being added
NA
Description of how you validated changes
Followed PRs that solved similar issues
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license