Skip to content

Conversation

alvazjor
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

Having a static readonly variable to manage the latest runtime version has proven to be challenging on NodeJS side, and a dynamic approach is preferred.

Description of changes

Changing the recently introduced PYTHON_LATEST static runtime to be a function. For now it will still deliver the latest python version available, but it will be changed into a dynamic approach later, similar to determineLatestNodeRuntime

Describe any new or updated permissions being added

NA

Description of how you validated changes

Updated existing unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 10, 2025 14:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 10, 2025
…on the scope, similar to latest node runtime
@alvazjor alvazjor force-pushed the alvazjor/python-latest branch from 229a3e0 to adef1ce Compare September 10, 2025 14:42
/**
* The latest Python version currently available in ALL regions.
*/
public static readonly PYTHON_LATEST = this.PYTHON_3_13;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change.

Copy link
Contributor Author

@alvazjor alvazjor Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has not been released. This static var was introduced recently, to have an alternative similar to NODEJS_LATEST, but that approach has historically had issues and a method is preferred. I am fixing it before we actually release it

@mrgrain mrgrain dismissed their stale review September 10, 2025 15:33

see comment

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 10, 2025
@leonmk-aws leonmk-aws self-assigned this Sep 10, 2025
Copy link
Contributor

mergify bot commented Sep 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cecbabf into main Sep 10, 2025
29 checks passed
@mergify mergify bot deleted the alvazjor/python-latest branch September 10, 2025 16:36
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants