fix(kms): cannot access aliasTargetKey on an Alias imported by Alias.fromAliasName #35521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fromAliasName If an Alias is ~~imported~~ referenced using `fromAliasName`, it doesn't have an `IKey` object it's associated with. If an Alias is then used in place of a Key and the consuming site uses the `IKey.keyRef` interface to obtain the key ARN, we should return the Alias ARN and not try to delegate to the underlying key... because there is none!
aws-cdk-automation
previously requested changes
Sep 18, 2025
otaviomacedo
approved these changes
Sep 18, 2025
mrgrain
added
the
pr-linter/exempt-integ-test
mrgrain
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Alias is
importedreferenced usingfromAliasName, it doesn't have anIKeyobject it's associated with.If an Alias is then used in place of a Key and the consuming site uses the
IKey.keyRefinterface to obtain the key ARN, we should return the Alias ARN and not try to delegate to the underlying key... because there is none!Closes #35520
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license