-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assets #371
Merged
Merged
Assets #371
Commits on Jul 18, 2018
-
Assets represent local files or directories which can be bundled as part of CDK constructs. During deployment, the toolkit will upload assets to the "Toolkit Bucket", and use CloudFormation Parameters to reference the asset in deploy-time. Assets expose the following deploy-time attributes: * s3BucketName * s3ObjectKey * s3Url Furthermore, the `asset.grantRead(principal)` will add IAM read permissions for the asset to the desired principal.
Elad Ben-Israel committedJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 5142934 - Browse repository at this point
Copy the full SHA 5142934View commit details -
Merge branch 'benisrae/s3-urls' into benisrae/assets
Elad Ben-Israel committedJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 34d213e - Browse repository at this point
Copy the full SHA 34d213eView commit details -
Elad Ben-Israel committed
Jul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 22128e5 - Browse repository at this point
Copy the full SHA 22128e5View commit details -
Elad Ben-Israel committed
Jul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 47643c4 - Browse repository at this point
Copy the full SHA 47643c4View commit details -
Updating integration test expectations
Elad Ben-Israel committedJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 05c0e8d - Browse repository at this point
Copy the full SHA 05c0e8dView commit details -
Merge branch 'benisrae/s3-urls' into benisrae/assets
Elad Ben-Israel committedJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 1e78025 - Browse repository at this point
Copy the full SHA 1e78025View commit details -
s3: bucketUrl and urlForObject(key) (#370)
The `bucketUrl` returns the URL of the bucket and `urlForObject(key)` returns the URL of an object within the bucket. Furthermore: `iam.IIdentityResource` was soft-renamed to `iam.IPrincipal` (IIdentityResource is still supported).
Elad Ben-Israel authoredJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 5502436 - Browse repository at this point
Copy the full SHA 5502436View commit details -
Merge remote-tracking branch 'origin/master' into benisrae/assets
Elad Ben-Israel committedJul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for b208b22 - Browse repository at this point
Copy the full SHA b208b22View commit details -
Elad Ben-Israel committed
Jul 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 0763282 - Browse repository at this point
Copy the full SHA 0763282View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.