Skip to content

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 21, 2019

We can't use lazy (or deploy-time) CIDRs when creating a VPC, since we
need to subdivide the CIDR for all the subnets. Throw a descriptive
error message to inform users when they try to do this.

Fixes #3617.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We can't use lazy (or deploy-time) CIDRs when creating a VPC, since we
need to subdivide the CIDR for all the subnets. Throw a descriptive
error message to inform users when they try to do this.

Fixes #3617.
@rix0rrr rix0rrr self-assigned this Aug 21, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@nija-at nija-at merged commit c92e9a9 into master Aug 21, 2019
@nija-at nija-at deleted the huijbers/cidr-error branch August 21, 2019 13:05
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting '${Token[TOKEN.72]} is not valid' error on cdk synth, when assigning ec2.Vpc.cidr value from cfnParameter.valueAsString
3 participants