feat(ecs): add automated spot instance draining support #4360

pahud · 2019-10-03T10:27:49Z

add spotInstanceDraining property to enable the Automated Spot Draining support for Amazon ECS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify · 2019-10-03T10:28:26Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-10-03T10:41:49Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-03T10:42:12Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-03T12:46:12Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-03T14:20:47Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-ecs/test/ec2/integ.spot-drain.ts

Pull request has been modified.

aws-cdk-automation · 2019-10-03T18:49:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-04T03:34:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb · 2019-10-04T05:16:22Z

@SoManyHs can you please review?

aws-cdk-automation · 2019-10-05T03:44:16Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-05T03:46:50Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk · 2019-10-08T15:34:27Z

@iamhopaul123 please review

aws-cdk-automation · 2019-10-08T16:03:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-ecs/lib/cluster.ts

packages/@aws-cdk/aws-ecs/README.md

packages/@aws-cdk/aws-ecs/test/ec2/integ.spot-drain.ts

* add unit test * remove redundant descriptions

Pull request has been modified.

aws-cdk-automation · 2019-10-09T14:17:51Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-09T14:21:31Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aining

aws-cdk-automation · 2019-10-09T15:09:53Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb · 2019-10-09T15:17:49Z

packages/@aws-cdk/aws-ecs/lib/cluster.ts

      autoScalingGroup.addUserData('echo ECS_AWSVPC_BLOCK_IMDS=true >> /etc/ecs/ecs.config');
    }

+    if (options.spotInstanceDraining) {


should we verify this ASG has spot capacity at all or maybe it doesn't really matter.

The classic ASG with launch configuration could be either all on-demand or all spot and ASG with mixed purchase options is another story.

Is it possible to determine if this ASG is all spot in the cluster.ts? If yes, then I prefer we enable this feature by default for the all spot ASG unless user explicitly turns it off. And for all on-demand ASG we turn it off.

At this moment, I leave this open to let user specify explicitly.

Oh, I think we can check if user specify the spotPrice property. If yes, then we turn on this by default unless user explicitly turn it off.

Thoughts?

If the default is off then that might be a breaking change which should be pushed off. I think eladb made a good point that we should check spot capacity first but the default from my perspective should remain the same.

fixed in ae46f3c

aws-cdk-automation · 2019-10-09T17:51:41Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-09T21:19:51Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-10-09T21:36:33Z

Thank you for contributing! Your pull request is now being automatically merged.

pahud requested a review from SoManyHs as a code owner October 3, 2019 10:27

pahud changed the title ~~add automated spot instance draining support~~ feat(aws-ecs): add automated spot instance draining support Oct 3, 2019

feat(aws-ecs): add automated spot instance draining support

06d9c33

use @see in comments

1c67537

eladb previously approved these changes Oct 3, 2019

View reviewed changes

packages/@aws-cdk/aws-ecs/test/ec2/integ.spot-drain.ts Outdated Show resolved Hide resolved

NGL321 assigned SoManyHs Oct 3, 2019

2 spaces indentation and simplify the integ content

b7939cd

pahud requested a review from eladb October 4, 2019 03:31

pahud added 2 commits October 5, 2019 11:03

update aws-ecs/README.md about Spot Instances.

0a9da21

fix typo

b012003

Merge branch 'master' into spot-draining

e9a5846

piradeepk requested a review from iamhopaul123 October 8, 2019 15:34

piradeepk assigned iamhopaul123 Oct 8, 2019

piradeepk changed the title ~~feat(aws-ecs): add automated spot instance draining support~~ feat(ecs): add automated spot instance draining support Oct 8, 2019

iamhopaul123 previously requested changes Oct 8, 2019

View reviewed changes

* update README

45bef1d

* add unit test * remove redundant descriptions

Merge branch 'master' into spot-draining

ed9ba7f

pahud added 2 commits October 9, 2019 22:28

fix trailing whitespace

df5092d

Merge branch 'spot-draining' of github.com:pahud/aws-cdk into spot-dr…

019896c

…aining

eladb reviewed Oct 9, 2019

View reviewed changes

- verify ASG has spot capacity only

ae46f3c

pahud requested review from iamhopaul123 and eladb October 9, 2019 18:06

Merge branch 'master' into spot-draining

acbaf72

iamhopaul123 approved these changes Oct 9, 2019

View reviewed changes

mergify bot merged commit 9c208d0 into aws:master Oct 9, 2019

feat(ecs): add automated spot instance draining support #4360

feat(ecs): add automated spot instance draining support #4360

Uh oh!

Conversation

pahud commented Oct 3, 2019

Uh oh!

mergify bot commented Oct 3, 2019

Uh oh!

aws-cdk-automation commented Oct 3, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 3, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 3, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 3, 2019

AWS CodeBuild CI Report

Uh oh!

Uh oh!

aws-cdk-automation commented Oct 3, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 4, 2019

AWS CodeBuild CI Report

Uh oh!

eladb commented Oct 4, 2019

Uh oh!

aws-cdk-automation commented Oct 5, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 5, 2019

AWS CodeBuild CI Report

Uh oh!

piradeepk commented Oct 8, 2019

Uh oh!

aws-cdk-automation commented Oct 8, 2019

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

eladb Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

pahud Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

pahud Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

iamhopaul123 Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

pahud Oct 9, 2019

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Oct 9, 2019

Uh oh!

Uh oh!