feat(lambda): configuration for async invocations #5299

jogold · 2019-12-04T18:07:16Z

Add support for destinations, maximum event age and maximum retry attempts for
asynchronous invocations.

Destinations are provided in @aws-cdk/aws-lambda-destinations.

See https://docs.aws.amazon.com/lambda/latest/dg/invocation-async.html

Closes #5239
Closes #5240

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Incomplete type definitions are unusable, so we translate them into "Json" to be able to something semi-useful. Fix some broken terminology in the specs and code generator.

mergify · 2019-12-04T18:07:56Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

jogold · 2019-12-04T18:08:34Z

Currently branched from https://github.com/aws/aws-cdk/tree/shivlaks/cfn-spec-update (#5297)

The only commit of interest here is 1dd219d.

aws-cdk-automation · 2019-12-04T18:17:12Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Add support for destinations, maximum event age and maximum retry attempts for asynchronous invocations. See https://docs.aws.amazon.com/lambda/latest/dg/invocation-async.html

aws-cdk-automation · 2019-12-04T21:26:18Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-04T21:32:56Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at

You should be able to pull out the cfnspec changes from here. This was already pulled in here - 7f33541

packages/@aws-cdk/aws-lambda-destinations/lib/event-bridge.ts

packages/@aws-cdk/aws-lambda-destinations/test/destinations.test.ts

packages/@aws-cdk/aws-lambda-destinations/lib/event-bridge.ts

Pull request has been modified.

aws-cdk-automation · 2019-12-08T09:04:34Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-08T17:05:03Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-08T20:08:08Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at

Does CloudFormation/Lambda allow multiple EventInvokeConfig resources for the same lambda function? What about combinations of EventInvokeConfig for the function, the function's version and alias?
To support imported lambda functions, versions and aliases, we should include an addEventInvokeConfig(...) method besides constructor props.

packages/@aws-cdk/aws-lambda-destinations/lib/event-bridge.ts

packages/@aws-cdk/aws-lambda/lib/event-invoke-config.ts

packages/@aws-cdk/aws-lambda/lib/function.ts

packages/@aws-cdk/aws-lambda/lib/alias.ts

aws-cdk-automation · 2019-12-17T14:51:41Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T08:30:30Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T08:33:50Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T08:44:59Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T09:45:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Pull request has been modified.

aws-cdk-automation · 2019-12-19T11:01:10Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-19T11:03:50Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at · 2019-12-19T14:20:49Z

@jogold - let me know if you're ok with the tweaks I've pushed to this PR.

As far as I can see, this is ready to be merged.

jogold · 2019-12-19T14:33:22Z

@jogold - let me know if you're ok with the tweaks I've pushed to this PR.

As far as I can see, this is ready to be merged.

LGTM!

aws-cdk-automation · 2019-12-19T14:44:50Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-19T16:40:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-19T17:10:55Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-19T18:11:55Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-12-19T18:57:45Z

Thank you for contributing! Your pull request is now being automatically merged.

shivlaks and others added 7 commits November 28, 2019 02:25

partial import with failures to address

8f01c1f

Rewrite incomplete types to "Json"

d664b1f

Incomplete type definitions are unusable, so we translate them into "Json" to be able to something semi-useful. Fix some broken terminology in the specs and code generator.

replace incomplete types as empty object

7308bc7

clean up CHANGELOG

a7580b0

remove conditional flow check for complex types without properties

008990b

update tests

8232865

fix codebuild tests

926813d

jogold requested review from eladb, nija-at, rix0rrr, shivlaks and skinny85 as code owners December 4, 2019 18:07

SomayaB assigned nija-at Dec 4, 2019

jogold force-pushed the lambda-destinations branch from 93bbc1f to 9d003b1 Compare December 4, 2019 21:14

feat(lambda): configuration options for async invocations

1dd219d

Add support for destinations, maximum event age and maximum retry attempts for asynchronous invocations. See https://docs.aws.amazon.com/lambda/latest/dg/invocation-async.html

jogold force-pushed the lambda-destinations branch from 9d003b1 to 1dd219d Compare December 4, 2019 21:20

nija-at previously requested changes Dec 8, 2019

View reviewed changes

packages/@aws-cdk/aws-lambda-destinations/lib/event-bridge.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-destinations/test/destinations.test.ts Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-destinations/lib/event-bridge.ts Outdated Show resolved Hide resolved

Merge branch 'master' into lambda-destinations

eb6c6ff

add test for default event bus

15d637e

add scope

5cb7f46

nija-at previously requested changes Dec 8, 2019

View reviewed changes

addVersion signature

ff27757

jogold added 2 commits December 18, 2019 09:20

Merge branch 'master' into lambda-destinations

ee67dc9

remove apigateway file

5e524dd

remove committed merge conflict

f4eb093

eslint in lambda-destinations

a25e787

Update documentation for addVersion()

6a8b8f3

Add node's path to the error message

3e76547

Change qualifier to protected access

e694962

Missed changing access in a few more places

20398e0

nija-at changed the title ~~feat(lambda): configuration options for async invocations~~ feat(lambda): configuration for async invocations Dec 19, 2019

Merge branch 'master' into lambda-destinations

d8838f6

missed one more place where qualifier needs to be protected

63274a3

nija-at approved these changes Dec 19, 2019

View reviewed changes

mergify bot merged commit 746ba32 into aws:master Dec 19, 2019

jogold deleted the lambda-destinations branch January 24, 2020 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): configuration for async invocations #5299

feat(lambda): configuration for async invocations #5299

jogold commented Dec 4, 2019 •

edited

Loading

mergify bot commented Dec 4, 2019

jogold commented Dec 4, 2019 •

edited

Loading

aws-cdk-automation commented Dec 4, 2019

aws-cdk-automation commented Dec 4, 2019

aws-cdk-automation commented Dec 4, 2019

nija-at left a comment

aws-cdk-automation commented Dec 8, 2019

aws-cdk-automation commented Dec 8, 2019

aws-cdk-automation commented Dec 8, 2019

nija-at left a comment •

edited

Loading

aws-cdk-automation commented Dec 17, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

nija-at commented Dec 19, 2019

jogold commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

mergify bot commented Dec 19, 2019

feat(lambda): configuration for async invocations #5299

feat(lambda): configuration for async invocations #5299

Conversation

jogold commented Dec 4, 2019 • edited Loading

mergify bot commented Dec 4, 2019

jogold commented Dec 4, 2019 • edited Loading

aws-cdk-automation commented Dec 4, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 4, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 4, 2019

AWS CodeBuild CI Report

nija-at left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 8, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 8, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 8, 2019

AWS CodeBuild CI Report

nija-at left a comment • edited Loading

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 17, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

nija-at commented Dec 19, 2019

jogold commented Dec 19, 2019

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

mergify bot commented Dec 19, 2019

jogold commented Dec 4, 2019 •

edited

Loading

jogold commented Dec 4, 2019 •

edited

Loading

nija-at left a comment •

edited

Loading