Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lambda destination api break error #5529

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Dec 23, 2019

since lambda destinations was a new module, it was published to npm before the actual release of the aws-lambda module. this causes the breaking change checker to fail because it could not find the required type in lambda


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

since lambda destinations was a new module, it was published to npm before the actual release of the aws-lambda module. this causes the breaking change checker to fail because it could not find the required type in lambda
@eladb
Copy link
Contributor Author

eladb commented Dec 23, 2019

copy @jogold

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2019
@eladb eladb merged commit acb3965 into master Dec 23, 2019
@eladb eladb deleted the benisrae/fix-lambda-destiantion-breaking-change-check branch December 23, 2019 14:16
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants