Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-event-sources): use of CfnParameter for maxBatchSize, retryAttempts & parallelizationFactor fails #9064

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jul 14, 2020

Code was not accounting for tokens in its validation checks. Added
support for tokens.

fixes #9044


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…yAttempts & parallelizationFactor fails

Code was not accounting for tokens in its validation checks. Added
support for tokens.
@nija-at nija-at requested a review from a team July 14, 2020 16:31
@nija-at nija-at self-assigned this Jul 14, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8e1a294
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4470e89 into master Jul 14, 2020
@mergify mergify bot deleted the nija-at/kinesis-eventsource-token branch July 14, 2020 17:18
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
…yAttempts & parallelizationFactor fails (aws#9064)

Code was not accounting for tokens in its validation checks. Added
support for tokens.

fixes aws#9044

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-lambda-event-sources] Unable to use CfnParameter valueAsNumber in KinesisEventSource
3 participants