Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2 create-tags doesn't allow tags via the "file" prefix #631

Closed
rfein-hearst opened this issue Feb 4, 2014 · 4 comments · Fixed by #640
Closed

ec2 create-tags doesn't allow tags via the "file" prefix #631

rfein-hearst opened this issue Feb 4, 2014 · 4 comments · Fixed by #640
Labels
bug This issue is a bug.

Comments

@rfein-hearst
Copy link

Since ec2 create-tags allows for tags to be supplied as JSON, I'd expect that I'd be able to supply that JSON via the "file" or "http" conventions - but it looks like the JSON has to actually supplied in-line on the command line. Not sure if this this behavior is expected or not - my assumption was that anywhere that JSON was used it could be as a file, but that may be incorrect.

aws ec2 create-tags  --tags file://tags.json  --resources i-12345678
Error parsing parameter --tags, should be: Key value pairs, with multiple values separated by a space.  
--tags Key=string,Value=string
@jamesls
Copy link
Member

jamesls commented Feb 5, 2014

This should work. What's the contents of your json file? It should look similar to the reference docs/man page:

JSON Syntax:

[
  {
    "Key": "string",
    "Value": "string"
  }
  ...
]

@rfein-hearst
Copy link
Author

Did some more digging - it was failing because the JSON file had a leading space on the first line. I don't believe leading whitespace should matter as the JSON is syntactically valid and passes jsonlint just fine, but sorry about the misleading initial issue.

@rfein-hearst
Copy link
Author

Problematic JSON:

 [
    {
        "Key": "test", 
        "Value": "test"
    }
]

@jamesls
Copy link
Member

jamesls commented Feb 5, 2014

I agree, the spacing should not matter. Looking into this.

@jamesls jamesls closed this as completed in 0fca1a8 Feb 7, 2014
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
* fix: Functional tests must run on localhost to work in Windows (aws#552)

* fix: spacing typo in Log statement in start-lambda (aws#559)

* docs: Fix syntax highlighting in README.md (aws#561)

* docs: Change jest to mocha in Nodejs init README (aws#564)

* docs: Fix @mhart link in README (aws#562)

* docs(README): removed cloudtrail, added SNS to generate-event (aws#569)

* docs: Update repo name references (aws#577)

* feat(debugging): Fixing issues around debugging Golang functions. (aws#565)

* fix(init): Improve current init samples around docs and fixes (aws#558)

* docs(README): Update launch config to SAM CLI from SAM Local (aws#587)

* docs(README): Update sample code for calling Local Lambda Invoke (aws#584)

* refactor(init): renamed handler for camel case, moved callback call up (aws#586)

* chore: aws-lambda-java-core 1.1.0 -> 1.2.0 for java sam init (aws#578)

* feat(validate): Add profile and region options (aws#582)

Currently, `sam validate` requires AWS Creds (due to the SAM Translator).
This commits adds the ability to pass in the credientials through a profile
that is configured through `aws configure`.

* docs(README): Update README prerequisites to include awscli (aws#596)

* fix(start-lambda): Remove Content-Type Header check (aws#594)

* docs: Disambiguation "Amazon Kinesis" (aws#599)

* docs: Adding instructions for how to add pyenv to your PATH for Windows (aws#600)

* docs: Update README with small grammar fix (aws#601)

* fix: Update link in NodeJS package.json (aws#603)

* docs: Creating instructions for Windows users to install sam (aws#605)

* docs: Adding a note directing Windows users to use pipenv (aws#606)

* fix: Fix stringifying λ environment variables when using Python2 (aws#579)

* feat(generate-event): Added support for 50+ events (aws#612)

* feat(invoke): Add region parameter to all invoke related commands (aws#608)

* docs: Breaking up README into separate files to make it easier to read (aws#607)

* chore: Update JVM size params to match docker-lambda (aws#615)

* feat(invoke): Invoke Function Without Parameters through --no-event (aws#604)

* docs: Update advanced_usage.rst with clarification on --env-vars usage (aws#610)

* docs: Remove an extra word in the sam packaging command (aws#618)

* UX: Improves event names to reflect Lambda Event Sources (aws#619)

* docs: Fix git clone typo in installation docs (aws#630)

* docs(README): Callout go1.x runtime support (aws#631)

* docs(installation): Update sam --version command (aws#634)

* chore(0.6.0): SAM CLI Version bump (aws#635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants