Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to verify that CLI examples only contain ascii #1882

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Mar 30, 2016

As part of this change I also fixed all the examples that failed
as a result of this test being added (#1873).

Also gives decent failure messages:

======================================================================
FAIL: tests.functional.docs.test_examples.test_all_examples_have_only_ascii('aws-cli/awscli/examples/autoscaling/describe-tags.rst',)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".virtualenvs/aws-cli/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "aws-cli/tests/functional/docs/test_examples.py", line 84, in verify_has_only_ascii_chars
    "\n\n%s\n" % (filename, line_number, error_text))
AssertionError: Non ascii characters found in the examples file aws-cli/awscli/examples/autoscaling/describe-tags.rst, line 53:

-auto-scaling-group —-starting-token Z
                    ^

cc @kyleknap @JordonPhillips

As part of this change I also fixed all the examples that failed
as a result of this test being added.
@JordonPhillips
Copy link
Member

⛵ This is what I get for staging my sed command in Notes

@jamesls jamesls merged commit b1aaaae into aws:develop Mar 30, 2016
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants