Skip to content

Conversation

vz10
Copy link
Contributor

@vz10 vz10 commented Jun 18, 2020

Issue #, if available: #5086

Description of changes:
Add support for AWS_CLI_FILE_ENCODING environment variable to cloudformation and eks customizations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vz10 vz10 requested review from stealthycoin and kyleknap June 18, 2020 02:08
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #5304 into v2 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #5304   +/-   ##
=======================================
  Coverage   94.33%   94.34%           
=======================================
  Files         234      234           
  Lines       17738    17741    +3     
=======================================
+ Hits        16734    16737    +3     
  Misses       1004     1004           
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.66% <100.00%> (+<0.01%) ⬆️
awscli/customizations/cloudformation/deploy.py 100.00% <100.00%> (ø)
awscli/customizations/eks/kubeconfig.py 95.00% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e977e...9e2f864. Read the comment docs.

@vz10 vz10 changed the title Add support for AWS_CLI_FILE_ENCODING environment variable to cloudformation and eks customizations [v2] Add support for AWS_CLI_FILE_ENCODING environment variable to cloudformation and eks customizations Jun 18, 2020
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@vz10 vz10 merged commit df7c46e into aws:v2 Jun 18, 2020
@vz10 vz10 deleted the fix_file_open branch June 18, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants