Skip to content

Conversation

boonew2
Copy link
Contributor

@boonew2 boonew2 commented Mar 20, 2020

Issue #, if available: N/A

Description of changes:
Using docker 18 in the standard:4.0 image runtime hopefully no longer lies to people about being version 19.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@subinataws
Copy link
Contributor

@boonew2 - Thanks for the contribution. Note that you do not need to specify docker versions in the runtime anymore. CodeBuild will default select the latest version for you, once you set the privileged mode as true for the Project. If you do specify a Docker version, it will be ignored and the latest version will be picked for the latest CodeBuild images. The print statement is misleading so will accept the PR for local builds.

version: 0.2

phases:
  build:
    commands:
      - docker -v

@subinataws subinataws merged commit ccda2c1 into aws:master Mar 20, 2020
@boonew2 boonew2 deleted the patch-1 branch March 20, 2020 16:46
@boonew2
Copy link
Contributor Author

boonew2 commented Mar 20, 2020

If you do specify a Docker version, it will be ignored and the latest version will be picked for the latest CodeBuild images

I noticed that the standard:3.0 runtime yml had a message that said that, but 4.0 went back to echo'ing the specific version so i wasn't sure what was happening behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants