Make unzipping fallback to unzip
#104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rubyzip` can have bugs that cause it to throw. If it throws, we will now try to see if unzip can handle the file on Linux systems.
|
The commit can't be pulled, could you update the tests? |
|
Did you get solution for above problem? I am still facing the issue |
|
Can you give examples for some of the exceptions you're seeing caused by rubyzip? This works on all platforms at the moment. If we add the fallback it will only work for linux and not windows so we should probably add an os check if we're indeed going to fall back. |
|
It turns out I was generating an invalid zip. This isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubyzipcan have bugs that cause it to throw. If it throws, we will now try to see if unzipcan handle the file on Linux systems.