Fix for #118 (agent hangs if STDOUT/STDERR left open by hook)

[jcttrll]

Here's a tentative fix for Issue #118. It's tested, and relatively simple. Other enhancements, like killing the STDOUT/STDERR pump threads when their joins time out, could easily be added.

A new error code, OUTPUTS_LEFT_OPEN_CODE = 6, is added to the ScriptError class. Presumably, this could be tied to information in the AWS Console for the failed event, possibly containing a link to helpful documentation?

[coveralls]

Coverage increased (+0.09%) to 94.673% when pulling 26d5ee4 on perihelios:outputs-left-open into c510185 on aws:master.

[ennala]

Any eta on what version this will be merged to ?

[CannibalVox]

Can this get merged? Would really like it if my timeouts actually uhhh.... timed out.

[obscurerichard]

yes please, I am seeing application hooks that hang forever instead of timing out too.

[achadha235]

Is this fix / issue still being tracked? I just ran into this problem while using AWS CodeStar.

[rohkat-aws]

@jcttrll we are currently reviewing your commit and apologies for the late reply.

[jpeddicord]

Hi @jcttrll,

Sorry for the run-around -- could you confirm that your contribution is being made under the terms of the Apache 2.0 license?

[jcttrll]

Hi, @jpeddicord,

Yes, my contribution is being made under the terms of the Apache 2.0 license.