Make github_api_url configurable
#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code change looks good, could you make sure the pull request can be released under term Apache License 2.0? |
|
Yeah, there shouldn't be any licensing issues with this (this PR is opened off of a fresh fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Code Deploy agent currently expects the Github API to be located at
https://api.github.com.For GitHub Enterprise users, this url could be at any other location (e.g.
https://development.my-company.com/api/v3).This pull request makes the api url configurable for people who want the agent to work with GHE. It should have no change to the default behavior.