Adding a slight retry whenever streaming the agent from S3. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerkes
reviewed
Jan 16, 2018
bin/install
Outdated
| end | ||
| rescue OpenURI::HTTPError => e | ||
| @log.error("Could not find package to download at '#{uri.to_s}'") | ||
| retry if (retries +=1) < 5 |
There was a problem hiding this comment.
I think adding a retry here is a good idea. However, I think we might want to address a couple considerations:
- The error that you mention in your ticket is a
OpenSSL::SSL::SSLError, which would not be handled here. It will just jump out of here anyway, so we probably want to add that to address the specific case. - Retries are a good addition to this call, but it would be best if we added exponential backoff to the retry to get the best results, which will give us more opportunities for success in cause the issue lasts for 5 rapid fire calls.
|
Hey, suggestions were updated on the PR code. Thanks for the feedback 👍 |
|
merged in a diff pull request #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Faced a few issues whenever connection to s3 drops by unexpected reason and installation remains hung. Added a slight retry attempt in case of network being disrupted , over-utilized or any packet drops happen. - Issue #95
Please feel free to contribute or to let me know further enhancements.