Merge Released And Current Approved Changes #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Merging in Deepankar (intern) concurrent deployment changes - Launching a separate ruby thread for executing commands
Issue he solved: If a CodeDeployment runs for more than 5 mins and the user starts another deployment, it fails after 5 minutes due to timeout as the Agent is busy executing the scripts. These changes makes the Agent to execute commands on separate threads which fixes the above mentioned issue..
Original cr shipped for Deepankar: https://code.amazon.com/reviews/CR-320735
2. Had to make modifications to fix bug: convert single thread.new to threadpool and gracefully shutdown waiting for all threads to finish, otherwise windows agent kills agent on restart in the middle of a deployment step
Dry-run build: https://build.amazon.com/1810132858
cr https://code.amazon.com/reviews/CR-1007891
1. Because windows doesn't know about shebang lines it doesn't know bin/codedeploy-local must be called with ruby so I fixed it to run with ruby prefix only if it's windows. 2. The appspec needed to be updated to include all the same hooks as linux. 3. Moved windows certificate configuration to before the first time aws sts is called instead of later on in the code path Dry-run build: https://build.amazon.com/1810143965 cr https://code.amazon.com/reviews/CR-1020258
other changes that had to be made to fix the tests to run on CodeBuild 1. Only try to upload to s3 bucket once (since both times are identical) - otherwise the permissions get messed up because of the assume role call 2. Not force permissions to be the shared file credentials so it can use the instance profile credentials. 3. Update the assume role policy since CodeBuild uses an assumed role so its role is a new one each time. cr https://code.amazon.com/reviews/CR-1255775
…commit hash (only available as an environment variable at build time) - this will let TOD check if a build succeeded cr https://code.amazon.com/reviews/CR-1334262
…ach thread so it never acknowledges a command without processing cr https://code.amazon.com/reviews/CR-1527032
… deleting the old deployment directories. cr https://code.amazon.com/reviews/CR-1710500
This fix has been added to ensure that agent safely fails to update or rollback during an ongoing deployment.Will make sure that our update event is an idempotent event. https://sim.amazon.com/issues/P11706277 cr https://code.amazon.com/reviews/CR-1814241
Prior to this change, We had removed the validation of the signed message during https://code.amazon.com/reviews/CR-1228125/revisions/1#/diff. This change will address the security concern the AWS Security team had about our validation.https://tt.amazon.com/E035418734 has more details. cr https://code.amazon.com/reviews/CR-2042604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theses changes will make the current Github repo in sync with current released and Approved Changes