Issue #185: fix for "Directory not empty @ dir_s_rmdir - /var/www" on Ubuntu 18.04 #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes codedeploy-agent compatible with Ubuntu 18.04 when deploying two different apps in the base common directory. ie.: - `/var/www/some-api/` - `/var/www/some-angular-app/` This works fine on Ubuntu 16.04, but you get the following error on Ubuntu 18.04 with ruby 2.5: `Unknown error, Directory not empty @ dir_s_rmdir - /var/www` It might not be the best way to do it, but it is meant to provide a solution until this officially gets fixed since it has been open since August 2018 already.
|
We have the same We get the same error when trying to delete a directory that is part of our app:
|
|
Close the CR in favor of #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #185 - ref.: AWSGLUE-713
Description of changes:
Simply added an error trapping directive and ignoring for the failing
rmdir.Makes codedeploy-agent compatible with Ubuntu 18.04 when deploying two different apps consecutively in the same base directory. ie.:
/var/www/some-api//var/www/some-angular-app/This works fine on Ubuntu 16.04, but you get the following error on Ubuntu 18.04 with Ruby 2.5:
Unknown error, Directory not empty @ dir_s_rmdir - /var/wwwIt might not be the best way to do it, but it is meant to provide a solution until this officially gets fixed since it has been open since August 2018 already. It's in line with the AWSGLUE-713 comment, and we've been successfully using this patch in development and production since then.
--
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.