Skip to content

Conversation

mujz
Copy link

@mujz mujz commented Jun 7, 2019

Issue #, if available: #214

Description of changes: Add support for Ruby 2.6 to the install script

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I already tested this and it seems to work just fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.679% when pulling daba769 on mujz:patch-1 into 7a58ba9 on aws:master.

@mujz
Copy link
Author

mujz commented Jun 13, 2019

Ping. Can an admin please look at this? It's very simple
@rohkat-aws @pmzara @annamataws

@inductor
Copy link

#196 This as well :(

@mujz
Copy link
Author

mujz commented Jun 15, 2019

Seems like nobody is maintaining this repo anymore :(

@rohkat-aws
Copy link
Contributor

the ruby 2.6 will have to be tested internally before we release it as a supported ruby version @mujz

@mujz
Copy link
Author

mujz commented Jun 17, 2019

Great to hear from you @rohkat-aws. Thanks for your input!
That makes sense. Would you be able to provide any input on how long it might take for the internal testing? I understand that it's hard to give time estimates, so I won't hold you to it. Just knowing whether this is something that somebody is working on or not is all I'm looking to know here.

@mujz
Copy link
Author

mujz commented Jul 15, 2019

@rohkat-aws any update on this? Last I heard from you was about 2 months ago.

@mujz mujz closed this Sep 30, 2019
@mujz mujz deleted the patch-1 branch September 30, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants