Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 2.6 to the install script #237

Conversation

cm-yoshida-takafumi
Copy link

*Issue #, if available: #214

*Description of changes:
Add support for Ruby 2.6 to the install script
And it works fine for me.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.497% when pulling 6774baa on cm-yoshida-takafumi:feature/support-ruby26 into 7fdda95 on aws:master.

@Helen1987
Copy link
Contributor

Unfortunately, this is not enough to support version 2.6. Check similar PR #172 (however, it is missing the change in update script ). Anyway, we are going to change our install script completely, so this PR most probably will be cancelled.

@cm-yoshida-takafumi
Copy link
Author

Sounds good. I'm looking forward to update!

@cm-yoshida-takafumi cm-yoshida-takafumi deleted the feature/support-ruby26 branch March 9, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants