-
Notifications
You must be signed in to change notification settings - Fork 188
Add support for running hooks with sudo #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cdcfcb6
adding support for sudo to run commands
bw-intuit dcebea9
adding tests
bw-intuit 4ab5388
adding support for sudo as root
bw-intuit d655c86
updated logs
bw-intuit 5c7977a
formatting
bw-intuit 8977f8a
formatting
bw-intuit 52ff3a6
changing logs to debug
bw-intuit 6ebece8
removing logs
bw-intuit 95bdba2
Updated to include modifications to allow running as non-root
ccloes-intuit d2c2053
updated to include additional debug message
ccloes-intuit 48b07f4
cleaning up code and fixing bug in sudo decision
bw-intuit 2654195
removing explicit return
bw-intuit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
require 'test_helper' | ||
|
||
class LinuxUtilTest < InstanceAgentTestCase | ||
context 'Testing building command with sudo' do | ||
setup do | ||
@script_mock = Struct.new :sudo, :runas | ||
end | ||
|
||
should 'return command with sudo with runas user deploy' do | ||
mock = @script_mock.new true, "deploy" | ||
assert_equal 'sudo su deploy -c my_script.sh', | ||
InstanceAgent::LinuxUtil.prepare_script_command(mock, "my_script.sh") | ||
end | ||
|
||
should 'return command without sudo with runas user deploy' do | ||
mock = @script_mock.new nil, "deploy" | ||
assert_equal 'su deploy -c my_script.sh', | ||
InstanceAgent::LinuxUtil.prepare_script_command(mock, "my_script.sh") | ||
end | ||
|
||
should 'return command without sudo or runas user' do | ||
mock = @script_mock.new nil, nil | ||
assert_equal 'my_script.sh', | ||
InstanceAgent::LinuxUtil.prepare_script_command(mock, "my_script.sh") | ||
end | ||
|
||
should 'return command with sudo' do | ||
mock = @script_mock.new true, nil | ||
assert_equal 'sudo my_script.sh', | ||
InstanceAgent::LinuxUtil.prepare_script_command(mock, "my_script.sh") | ||
end | ||
|
||
end | ||
end | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses systemctl to run start, stop, restart commands. systemctl doesn't stop the agent for the first time when you issue the stop command. This seems to be happening only on RHEL boxes. Could you please address this issue before we could release the changes?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is already merged, I will add a new PR with logic to check for RHEL 7. Will that suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be fine to do so. Thanks a lot!