Skip to content

chore: Add GSI for virtual beacon example to test table #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2023
Merged

chore: Add GSI for virtual beacon example to test table #178

merged 3 commits into from
May 16, 2023

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to ESDK CI May 11, 2023 23:05 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 mentioned this pull request May 11, 2023
Merged
josecorella
josecorella previously approved these changes May 16, 2023
View reviewed changes
@josecorella
Copy link
Contributor

make sure to deploy cfn change before merging

@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 19:37 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:21 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:21 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:32 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:32 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:32 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:32 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 20:46 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:45 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:45 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:45 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to MPL CI May 16, 2023 21:45 — with GitHub Actions Inactive
josecorella
josecorella approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucasmcdonald3 lucasmcdonald3 merged commit 4277fc3 into main May 16, 2023
@lucasmcdonald3 lucasmcdonald3 deleted the lucmcdon-cfn-virtual branch May 16, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmcdonald3 @josecorella