-
Notifications
You must be signed in to change notification settings - Fork 102
Pubsub in ci #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub in ci #181
Conversation
Why not use github actions to run the samples as well? Feel like if we can add tests steps to |
We can't use internal VPC infrastructure then: no proxies, no event stream servers, no gg cores |
Do we need proxies and gg cores for pubsub sample? |
Atm? no. Eventually? yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, just feel like if we can have at least one sample (pubsub that only needs the credentials to run) runs across platform, we can be more confident. For the other samples, we need the internal environment for sure. Anyway, this is good! We finally have our samples tested!🙆♂️
I think what you're thinking of here is a separate {OS x Architecture} test set that would verify/validate that all of the expected, embedded native libraries are present and invoked properly. We could definitely do that with containers/builder but probably limit it to just successfully creating a single native resource (elg, for example). Ideally, we should do it as a RC test step in CD pipelines as well. I'm going to add both of these ideas to the IoT Quality doc. The SDKs themselves are platform/arch agnostic, so if you screw up something at that level, we don't want to find it out when running CI on the SDKs, instead we want to find out earlier in either the native library (io/cal/common) or the appropriate CRT. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.