Skip to content

Conversation

bretambrose
Copy link
Contributor

  • Run pub sub node sample with both direct mqtt and websocket configurations in CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK
Copy link
Contributor

TingDaoK commented Aug 4, 2021

Why not use github actions to run the samples as well? Feel like if we can add tests steps to builder.json. We can store the credentials in github secrets as what we did for other repos? In this way we can test it across platform?

@bretambrose
Copy link
Contributor Author

Why not use github actions to run the samples as well? Feel like if we can add tests steps to builder.json. We can store the credentials in github secrets as what we did for other repos? In this way we can test it across platform?

We can't use internal VPC infrastructure then: no proxies, no event stream servers, no gg cores

@TingDaoK
Copy link
Contributor

TingDaoK commented Aug 4, 2021

Why not use github actions to run the samples as well? Feel like if we can add tests steps to builder.json. We can store the credentials in github secrets as what we did for other repos? In this way we can test it across platform?

We can't use internal VPC infrastructure then: no proxies, no event stream servers, no gg cores

Do we need proxies and gg cores for pubsub sample?

@bretambrose
Copy link
Contributor Author

Why not use github actions to run the samples as well? Feel like if we can add tests steps to builder.json. We can store the credentials in github secrets as what we did for other repos? In this way we can test it across platform?

We can't use internal VPC infrastructure then: no proxies, no event stream servers, no gg cores

Do we need proxies and gg cores for pubsub sample?

Atm? no. Eventually? yes.

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, just feel like if we can have at least one sample (pubsub that only needs the credentials to run) runs across platform, we can be more confident. For the other samples, we need the internal environment for sure. Anyway, this is good! We finally have our samples tested!🙆‍♂️

@bretambrose
Copy link
Contributor Author

bretambrose commented Aug 5, 2021

yeah, just feel like if we can have at least one sample (pubsub that only needs the credentials to run) runs across platform, we can be more confident. For the other samples, we need the internal environment for sure. Anyway, this is good! We finally have our samples tested!ok_man

I think what you're thinking of here is a separate {OS x Architecture} test set that would verify/validate that all of the expected, embedded native libraries are present and invoked properly. We could definitely do that with containers/builder but probably limit it to just successfully creating a single native resource (elg, for example). Ideally, we should do it as a RC test step in CD pipelines as well. I'm going to add both of these ideas to the IoT Quality doc.

The SDKs themselves are platform/arch agnostic, so if you screw up something at that level, we don't want to find it out when running CI on the SDKs, instead we want to find out earlier in either the native library (io/cal/common) or the appropriate CRT.

@bretambrose bretambrose merged commit e34d379 into main Aug 5, 2021
@bretambrose bretambrose deleted the PubsubInCi branch August 5, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants