-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single node Neuron test to the e2e tester #450
Conversation
also please add a CI job that tests the image build for the new dockerfile 👍 |
@@ -0,0 +1,5 @@ | |||
# Start with the NVIDIA CUDA base image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this in addition to Dockerfile.neuronx-tests, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've got dupes of these files with and without extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we're just lifting these from somewhere else, can you add code comments in the scripts with permalinks to the original source?
4d97016
to
47c9852
Compare
Issue #, if available:
Description of changes:
This PR adds single-node Neuron tests to the e2e2 tester. These tests serve as unit tests for the Neuron device and include the following:
These test scripts are replicated from https://github.com/aws/deep-learning-containers/blob/master/test/dlc_tests/container_tests/bin/pytorch_tests
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.