Emit multi-line logs with timestamps #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
alex-pewpew
reviewed
Feb 15, 2023
| @@ -1027,6 +1046,7 @@ def test_log_error_invokeId_line_framed_log_sink(self): | |||
| "testrequestId", | |||
| ) | |||
| bootstrap.log_error(err_to_log, log_sink) | |||
| after = int(time.time_ns() / 1000) | |||
There was a problem hiding this comment.
nit: adding randomness into unit tests is discouraged. In this particular case it should not cause losing determinism, so it's fine to leave if here
| @@ -335,7 +335,8 @@ def __exit__(self, exc_type, exc_value, exc_tb): | |||
|
|
|||
| def log(self, msg): | |||
| encoded_msg = msg.encode("utf8") | |||
| log_msg = self.frame_type + len(encoded_msg).to_bytes(4, "big") + encoded_msg | |||
| timestamp = int(time.time_ns() / 1000) # UNIX timestamp in microseconds | |||
There was a problem hiding this comment.
Using // should be a cleaner way to show that it's not a type conversion
alex-pewpew
approved these changes
Feb 15, 2023
briensea
approved these changes
Feb 15, 2023
andclt
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Lambda accepts multi-line messages where the timestamp of the log emission is encoded in the log event header. This helps ordering the function emitted messages with regards to platform emitted messages, e.g. START, REPORT.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.