Skip to content

refactor test cases #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2024
Merged

refactor test cases #119

merged 5 commits into from
Apr 19, 2024

Conversation

roger-zhangg
Copy link
Member

@roger-zhangg roger-zhangg commented Apr 11, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • refactor testcases to
    • use python3.12
    • respect docker arch
    • run different arch in parallel gh actions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@roger-zhangg roger-zhangg marked this pull request as draft April 11, 2024 18:03
@roger-zhangg roger-zhangg marked this pull request as ready for review April 11, 2024 18:44
valerena
valerena reviewed Apr 16, 2024
View reviewed changes
valerena
valerena reviewed Apr 18, 2024
View reviewed changes
@roger-zhangg
Copy link
Member Author

Thanks @valerena for the catches! I think now it's ready for a final review, thanks!

@valerena valerena merged commit fe11d78 into aws:develop Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valerena valerena valerena approved these changes

@mbfreder mbfreder Awaiting requested review from mbfreder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger-zhangg @valerena